Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: option to skip stop local node screen #3734

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Nov 15, 2021

Closes #3732

Needs good testing as I had issues with settings resetting after running this patch.

@rating89us
Copy link
Contributor

It seems that it's not possible to save any value to persistentSettings after wallet "close event" is called.

That is the reason why I decided to implement a dropdown on Settings > Node page in #2898, and that's why I wasn't able to implement a "Don't ask me again" checkbox on the dialog.

Please check #2898.

@selsta
Copy link
Collaborator Author

selsta commented Nov 21, 2021

It seems that it's not possible to save any value to persistentSettings after wallet "close event" is called.

I don't change any value after the "close event" is called is called.

That is the reason why I decided to implement a dropdown on Settings > Node page in #2898, and that's why I wasn't able to implement a "Don't ask me again" checkbox on the dialog.

I basically did the same, just on the Settings -> Interface page where it fits better IMO.

@plowsof
Copy link
Contributor

plowsof commented Jul 9, 2022

The new checkbox in settings -> interface highlighted below:
dprompt
works as intended, ive tried combinations of setting / un-setting / closing / opening wallet and all changes persisted / acted correctly.

The only improvement i can think of would be to perhaps add something along the lines of ' Disable this prompt in settings -> interface ' here: (a new string to avoid translation nightmares? if this is causing headaches let me know)

confirmationDialog.text = qsTr("Do you want to stop local node or keep it running in the background?") + translationManager.emptyString;

i prefer this PR over #2898 , simpler / elegant
LGTM

@luigi1111 luigi1111 merged commit b7ab507 into monero-project:master Aug 10, 2022
@selsta selsta deleted the ask-localnode-exit branch August 10, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the option to disable the "Do you want to stop local node" screen.
4 participants